Skip to content

Entropy fix#356

Open
collinc04 wants to merge 33 commits into
mainfrom
entropy-fix
Open

Entropy fix#356
collinc04 wants to merge 33 commits into
mainfrom
entropy-fix

Conversation

@collinc04
Copy link
Copy Markdown
Contributor

Entropy fix

Description

Updated .gitignore to untrack all .ufv2 as well as fixed hardware entropy warnings by updating zephyr and adding appropriate device to device tree

nateinaction and others added 2 commits March 2, 2026 17:34
Co-authored-by: Collin Cook <collincook5804@gmail.com>
@collinc04 collinc04 requested a review from nateinaction March 5, 2026 19:14
@collinc04 collinc04 enabled auto-merge (squash) March 5, 2026 21:30
@nateinaction nateinaction disabled auto-merge March 5, 2026 23:42
Copy link
Copy Markdown
Collaborator

@nateinaction nateinaction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll wait on the next Zephyr release in April to pull this in.

- clock
- counter
- dma
- entropy
Copy link
Copy Markdown
Collaborator

@nateinaction nateinaction Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we don't need these yaml entries.

Suggested change
- entropy

Comment on lines +21 to +25
# SOC
CONFIG_ENTROPY_GENERATOR=y
CONFIG_ENTROPY_DEVICE_RANDOM_GENERATOR=y

# TCA
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't need this either. I was able to build and entropy remained enabled without this.

Suggested change
# SOC
CONFIG_ENTROPY_GENERATOR=y
CONFIG_ENTROPY_DEVICE_RANDOM_GENERATOR=y
# TCA

- clock
- counter
- dma
- entropy
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- entropy

@hrfarmer hrfarmer moved this to Testing in V1.X.X Mar 20, 2026
@hrfarmer hrfarmer moved this from Testing to To Understand in V1.X.X Mar 20, 2026
@ineskhou ineskhou moved this from To Understand to Blocked in V1.X.X Mar 20, 2026
@collinc04
Copy link
Copy Markdown
Contributor Author

#359

Going to hit this with the pico debug, and hopefully get to the bottom of what's causing the issue. Maybe will need to open an issue with upstream Zephyr?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 385675b7-81a5-4aab-adc6-c2bdc9fbba78

📥 Commits

Reviewing files that changed from the base of the PR and between 7a9b8e9 and 1d14e22.

📒 Files selected for processing (3)
  • boards/bronco_space/proves_flight_control_board_v5/proves_flight_control_board_v5.dtsi
  • prj.conf
  • west.yml

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Enabled random number generator (RNG) hardware block for the Bronco Space flight control board.
  • Updates

    • Upgraded Zephyr core to v4.4.0.
    • Updated cryptographic and hardware abstraction layer modules to latest pinned versions.

Walkthrough

Three configuration changes across device tree, build settings, and manifest dependencies. The RNG hardware block is enabled on the flight control board, a log level override is removed from project configuration, and Zephyr is bumped from v4.3.0 to v4.4.0 with tinycrypt replaced by tf-psa-crypto.

Changes

Cohort / File(s) Summary
Device Tree Configuration
boards/bronco_space/proves_flight_control_board_v5/proves_flight_control_board_v5.dtsi
Enables RNG hardware block by setting status to "okay".
Build Configuration
prj.conf
Removes explicit log level default (CONFIG_LOG_DEFAULT_LEVEL=3) while keeping logging disabled.
Manifest Configuration
west.yml
Bumps Zephyr from v4.3.0 to v4.4.0, updates module revisions (cmsis_6, hal_rpi_pico, hal_st, picolibc, mbedtls, mcuboot), and replaces tinycrypt with tf-psa-crypto as the crypto module.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Poem

🐰 Hops of joy through config files so fine,
RNG enabled, dependencies align,
From tinycrypt's past to PSA's new way,
Zephyr flies higher, updated today!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a brief summary of changes but is significantly incomplete compared to the template requirements. Critical sections including Related Issues/Tickets, How Has This Been Tested (with checkboxes), Screenshots/Recordings, and the full Checklist are entirely missing. Complete the pull request description by adding all template sections: link related issues, document testing approach with checkboxes, add screenshots if applicable, and complete the required checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Entropy fix' is concise and directly relates to the primary changes in the pull request, which center on fixing hardware entropy warnings and updating Zephyr accordingly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Blocked

Development

Successfully merging this pull request may close these issues.

4 participants