Open
Conversation
When PROJECT_VENDOR is not set it is treated as an empty string
in the path ${CMAKE_CURRENT_SOURCE_DIR}/${PROJECT_VENDOR}/CMakeLists.txt.
Since examples/legacy_apps/machine/CMakeLists.txt exists, the condition
evaluates to true even though PROJECT_VENDOR is not defined.
Fix this by explicitly testing that PROJECT_VENDOR is defined before
checking for the vendor-specific CMakeLists.txt.
Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
The purpose of legacy_apps is to provide examples, so it makes sense to have this configuration enabled by default. This also fixes a compatibility issue with legacy scripts used, for instance, in the open-amp CI. Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Collaborator
Author
|
@bentheredonethat please could you have a look |
Contributor
|
@arnopo LGTM |
tnmysh
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aim of this PR is to fix open-amp CI issue https://github.com/OpenAMP/open-amp/actions/runs/21977010300/job/63490789192?pr=676 introduced by #83