Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions config/bidderinfo.go
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,9 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi
}

parentBidderInfo := bidderInfos[aliasBidderInfo.AliasOf]
// Note: The aliasBidderInfo.GVLVendorID is intentionally never set to the parent's
// GVLVendorID. Each alias must declare its own GVL Vendor ID, as inheriting from the
// parent is not safe for legal reasons.
if aliasBidderInfo.AppSecret == "" {
aliasBidderInfo.AppSecret = parentBidderInfo.AppSecret
}
Expand All @@ -391,9 +394,6 @@ func processBidderAliases(aliasNillableFieldsByBidder map[string]aliasNillableFi
if aliasBidderInfo.ExtraAdapterInfo == "" {
aliasBidderInfo.ExtraAdapterInfo = parentBidderInfo.ExtraAdapterInfo
}
if aliasBidderInfo.GVLVendorID == 0 {
aliasBidderInfo.GVLVendorID = parentBidderInfo.GVLVendorID
}
if aliasBidderInfo.Maintainer == nil {
aliasBidderInfo.Maintainer = parentBidderInfo.Maintainer
}
Expand Down
3 changes: 2 additions & 1 deletion config/bidderinfo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ func TestProcessBidderInfo(t *testing.T) {
},
},
ExtraAdapterInfo: "extra-info",
GVLVendorID: 42,
GVLVendorID: 0,
Maintainer: &MaintainerInfo{
Email: "some-email@domain.com",
},
Expand Down Expand Up @@ -392,6 +392,7 @@ func TestProcessAliasBidderInfo(t *testing.T) {
}
bidderB := parentWithSyncerKey
bidderB.AliasOf = "bidderA"
bidderB.GVLVendorID = 0
bidderB.Syncer = &Syncer{
Key: bidderB.Syncer.Key,
}
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/adform.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: adf
gvlVendorID: 50
userSync:
redirect:
url: "https://c1.adform.net/cookie?redirect_url={{.RedirectURL}}"
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/admaticde.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "admatic"
aliasOf: "admatic"
gvlVendorID: 1281
1 change: 1 addition & 0 deletions static/bidder-info/copper6.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: adtelligent
endpoint: "http://ghb.app.copper6.com/pbs/ortb"
maintainer:
email: "info@copper6.com"
gvlVendorID: 1356
userSync:
# Copper6 ssp supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/epsilon.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: conversant
gvlVendorID: 24
userSync:
redirect:
url: "https://prebid-match.dotomi.com/match/bounce/current?version=1&networkId=72582&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&rurl={{.RedirectURL}}"
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/equativ.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "smartadserver"
gvlVendorID: 45
3 changes: 2 additions & 1 deletion static/bidder-info/finative.yaml
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
endpoint: "https://b.finative.cloud/cds/rtb/bid?ssp={{.AccountID}}"
aliasOf: "seedingAlliance"
aliasOf: "seedingAlliance"
gvlVendorID: 371
1 change: 1 addition & 0 deletions static/bidder-info/freewheel-ssp.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: freewheelssp
gvlVendorID: 285
userSync:
iframe:
url: "https://ads.stickyadstv.com/pbs-user-sync?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&r={{.RedirectURL}}"
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/indicue.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: adtelligent
endpoint: "http://ghb.console.indicue.com/pbs/ortb"
maintainer:
email: "ops@indicue.com"
gvlVendorID: 410
userSync:
# Indicue ssp supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/janet.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: adtelligent
endpoint: "http://ghb.bidder.jmgads.com/pbs/ortb"
maintainer:
email: "info@thejmg.com"
gvlVendorID: 410
userSync:
# JANet supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/magnite.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: "rubicon"
aliasOf: "rubicon"
gvlVendorID: 52
3 changes: 2 additions & 1 deletion static/bidder-info/monetixads.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
aliasOf: "admatic"
maintainer:
email: "team@monetixads.com"
email: "team@monetixads.com"
gvlVendorID: 1281
3 changes: 2 additions & 1 deletion static/bidder-info/netaddiction.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
aliasOf: "admatic"
maintainer:
email: "publishers-support@netaddiction.it"
email: "publishers-support@netaddiction.it"
gvlVendorID: 1281
1 change: 1 addition & 0 deletions static/bidder-info/pgam.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: adtelligent
endpoint: "http://ghb.pgamssp.com/pbs/ortb"
maintainer:
email: "ppatel@pgammedia.com"
gvlVendorID: 1353
userSync:
# PGAM ssp supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/pixad.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
aliasOf: "admatic"
maintainer:
email: "prebid@pixad.com.tr"
email: "prebid@pixad.com.tr"
gvlVendorID: 1281
2 changes: 2 additions & 0 deletions static/bidder-info/showheroes-bs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
aliasOf: "showheroes"
gvlVendorID: 111
2 changes: 2 additions & 0 deletions static/bidder-info/showheroesBs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
aliasOf: "showheroes"
gvlVendorID: 111
1 change: 1 addition & 0 deletions static/bidder-info/streamkey.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: adtelligent
endpoint: "http://ghb.hb.streamkey.net/pbs/ortb"
maintainer:
email: "contact@streamkey.tv"
gvlVendorID: 410
capabilities:
app:
mediaTypes:
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/tagoras.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ aliasOf: "vidazoo"
endpoint: "https://exchange.tagoras.io/openrtb/"
maintainer:
email: "prebid@tagoras.io"
gvlVendorID: 1450
userSync:
iframe:
url: https://sync.tagoras.io/api/user/html/6819bdc3e6bb44545c55f843?pbs=true&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/ttd.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
aliasOf: thetradedesk
gvlVendorID: 21
1 change: 1 addition & 0 deletions static/bidder-info/yahooAdvertising.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
aliasOf: yahooAds
gvlVendorID: 25
userSync:
# yahooAdvertising supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
1 change: 1 addition & 0 deletions static/bidder-info/yahoossp.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
aliasOf: yahooAds
maintainer:
email: "hb-fe-tech@oath.com"
gvlVendorID: 25
userSync:
# yahoossp supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
Expand Down
3 changes: 2 additions & 1 deletion static/bidder-info/yobee.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
aliasOf: "admatic"
maintainer:
email: "adops@yobee.it"
email: "adops@yobee.it"
gvlVendorID: 1281
Loading