Rename ext.prebid to ext.openads while still allowing both#137
Merged
Conversation
Remove floors parsing as it isn't necessary
Remove added newlines
jbingham94
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ext.openads as an inbound alias for ext.prebid at both request.ext and imp[].ext. Outbound bidder requests still use ext.prebid; the SIS signature block on ext.openads is unaffected.
If both keys are present, openads wins and prebid is fully ignored — no fallback for missing subkeys. Request-level and imp-level resolve independently, so mixing is fine.
The alias is handled at four points: the RequestExt/ImpExt wrappers (map-level rewrite), ExtRequest.UnmarshalJSON (for code that deserializes ExtRequest directly), getExtPrebidValue in the auction endpoint (raw JSON paths for stored requests and passthrough), and splitImps in exchange (bidder routing).
This can be simplified once we deprecate ext.prebid