fix: add input validation for dataset path — show helpful error for missing files (#118)#158
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…OpenAgentHQ#118) _validate_path now raises DatasetNotFoundError with a user-friendly message showing the missing path, current working directory, and a tip about using absolute paths. Early validation also added to _get_loader in factory.py for fail-fast behaviour. Closes OpenAgentHQ#118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add input validation for dataset path with helpful error message
When a user specifies a dataset path that doesn't exist, the error message was a generic
DatasetNotFoundError. Now it shows:Changes
openagent_eval/datasets/base.py— Enhanced_validate_path()to include current working directory and usage tip in the error details.openagent_eval/datasets/factory.py— Added early path validation in_get_loader()for fail-fast behaviour before loader selection.Fixes #118
Support my work: If this fix helped, consider buying me a coffee at https://buymeacoffee.com/muhamedfazalps ☕