Skip to content

fix: use ReportConfig.max_examples instead of hardcoded limits (#114)#161

Open
fazalpsinfo-cmyk wants to merge 1 commit into
OpenAgentHQ:mainfrom
fazalpsinfo-cmyk:fix/max-examples-114
Open

fix: use ReportConfig.max_examples instead of hardcoded limits (#114)#161
fazalpsinfo-cmyk wants to merge 1 commit into
OpenAgentHQ:mainfrom
fazalpsinfo-cmyk:fix/max-examples-114

Conversation

@fazalpsinfo-cmyk

Copy link
Copy Markdown

Fix: ReportConfig.max_examples ignored

Three report generators hardcoded their sample/error limits instead of reading ReportConfig.max_examples:

File Before After
terminal.py results[:5] results[:config.report.max_examples]
markdown.py (errors) errors[:10] errors[:config.report.max_examples]
markdown.py (samples) min(len(results), 10) min(len(results), config.report.max_examples)

html.py and json_report.py already iterated over all results without a limit, so they were left unchanged.

Fixes #114


Support my work: If this fix helped, consider buying me a coffee at https://buymeacoffee.com/muhamedfazalps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: ReportConfig.max_examples is ignored — each report generator hardcodes its limit

1 participant