fix: non-ASCII characters silently ignored in content gap analysis (#122)#163
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: non-ASCII characters silently ignored in content gap analysis (#122)#163fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…penAgentHQ#122) The content gap detection used [a-zA-Z] which only matches ASCII letters, silently ignoring non-ASCII characters (accented chars, CJK, emoji, etc.). Replaced with [^\W\d_] which matches any Unicode letter in Python 3's Unicode-aware re module. Fixes OpenAgentHQ#122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Non-ASCII characters in content gap detection
The regex
[a-zA-Z]in_check_content_gapsonly matches ASCII letters,silently ignoring non-ASCII characters (accented chars, CJK, emoji, etc.).
Replaced with
[^\W\d_]which matches any Unicode letter in Python 3'sUnicode-aware
remodule. This is a one-character change with no behavioralimpact on ASCII-only content.
Fixes #122
Support my work: https://buymeacoffee.com/muhamedfazalps