Fix #77: Remove orphan LLMResponse construction in anthropic generate()#166
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
Fix #77: Remove orphan LLMResponse construction in anthropic generate()#166fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
…ic generate() The LLMResponse object was constructed but never assigned or returned. The generate() method returns a plain str, making this dead code. Also cleans up the unused LLMResponse import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #77
Summary
Removes the orphan
LLMResponse(...)construction in theAnthropic.generate()method that was created but never assigned or returned. The method returns a plainstr, making this object construction dead code on every LLM call.Changes
LLMResponse(...)constructor call (lines 204-211)LLMResponseimportImpact
https://buymeacoffee.com/muhamedfazalps