fix(exceptions): include diagnosis step in error details#192
Merged
bityodha merged 2 commits intoJul 17, 2026
Conversation
Diagnosis execution errors stored the failed step only as an attribute, leaving logs and rendered error details without the relevant context. Add it to the details mapping and cover the behavior with a regression test.
|
🎉 Congratulations @Sanjays2402! Your pull request has been successfully merged into main. 🚀 Thank you for contributing to OpenAgentHQ and helping improve the project. We truly appreciate your contribution and hope to see you back with more amazing PRs! Happy Open Sourcing! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include the failed diagnosis step in
DiagnosisExecutionError.detailsso logs and rendered errors retain that context.Type of Change
Related Issues
Closes #69
How Has This Been Tested?
The regression fails on the original source and passes with this fix. All 27 exception tests and changed-file Ruff checks pass.
uv run pytest)uv run ruff check .)uv run mypy openagent_eval/)Checklist
Screenshots (if applicable)
N/A
Additional Notes
Changed-file mypy reports the same two pre-existing bare-
dicterrors with and without this patch.