fix(proxy): propagate noProxy on startup and UI reload#274
Open
snvtac wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy.noProxyinto the CLI cold-start proxy installer.NO_PROXYandno_proxyfor the UI runtime env when a proxy URL is configured.Root cause
proxy.noProxywas stored in config and respected by the CLI hot-reload path, but the cold-start call only passedproxy.url. The UI runtime env also exported onlyHTTPS_PROXY/https_proxy, so spawned UI runtime processes did not receive the configured bypass list. During review, the reload path also needed cleanup so removed proxy settings do not leave stale env vars or dispatcher state behind.Closes #253.
Validation
npm testpnpm --dir ui test pilotdeckConfig.test.js pilotdeckConfigReloader.test.jsNote: I also ran
pnpm --dir ui test; it currently fails in unrelated existing streaming/session tests (streamSmoother.test.tsanduseSessionStore.streaming.test.ts) that are outside this PR's touched files.