Changed the behaviour of the masking mechanism: When the selector is …#692
Open
habruening wants to merge 2 commits intoOpenBoard-org:devfrom
Open
Changed the behaviour of the masking mechanism: When the selector is …#692habruening wants to merge 2 commits intoOpenBoard-org:devfrom
habruening wants to merge 2 commits intoOpenBoard-org:devfrom
Conversation
…clicked in desktop mode, all annotations disappear so that the user can work with the desktop. Platforms where the masking mechanism is not needed (Windows) are not affected. The original behaviour in this case has not been changed.
Author
|
Pull request #895 is an alternative to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the behaviour of the masking mechanism. In the current version it does not work. If the user has added annotations over the desktop, he has no chance to work with the desktop any more. The masking mechanism prevents him from interacting with the desktop.
So I improved this behaviour. As the selector button has no use in that case (because you cannot click through annotations anyway), I changed the behaviour of the selector. It hides all annotations and minimizes the desktop palette. Then the user can operate with the desktop. When he wants the annotations back, he just maximizes the desktop palette again.
Hiding the desktop palette may be a bit surprising in this situation. But as the user cannot draw annotations, there is actually no real need of having the desktop palette maximized.