Fix QuestDB playback hangs by using thread-local PG connections#2948
Open
Fix QuestDB playback hangs by using thread-local PG connections#2948
Conversation
The shared singleton PG::Connection with a mutex only guarding creation (not usage) allowed multiple puma threads to call exec_params concurrently on the same connection. PG::Connection is not thread-safe, causing queries to hang for minutes and starving the thread pool, which resulted in "no response received" errors on the frontend during playback. Switch to thread-local connections via Thread.current[:questdb_conn] so each puma thread gets its own PG connection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2948 +/- ##
==========================================
- Coverage 78.48% 78.47% -0.01%
==========================================
Files 673 673
Lines 55333 55334 +1
Branches 728 728
==========================================
- Hits 43428 43425 -3
- Misses 11827 11831 +4
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared singleton PG::Connection with a mutex only guarding creation (not usage) allowed multiple puma threads to call exec_params concurrently on the same connection. PG::Connection is not thread-safe, causing queries to hang for minutes and starving the thread pool, which resulted in "no response received" errors on the frontend during playback.
Switch to thread-local connections via Thread.current[:questdb_conn] so each puma thread gets its own PG connection.