Skip to content

Record the 'stored' flag as lowercase true/false#2949

Open
jmthomas wants to merge 3 commits intomainfrom
stored
Open

Record the 'stored' flag as lowercase true/false#2949
jmthomas wants to merge 3 commits intomainfrom
stored

Conversation

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Mar 6, 2026

closes #2947

No other changes are needed because when we deserialize the value we call ConfigParser.handle_true_false which calls upper and compares with TRUE and FALSE.

@jmthomas jmthomas requested review from ryan-pratt and ryanmelt March 6, 2026 20:24
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (71c95ef) to head (ae829cd).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   78.48%   78.49%           
=======================================
  Files         673      673           
  Lines       55333    55333           
  Branches      728      728           
=======================================
+ Hits        43428    43433    +5     
+ Misses      11827    11822    -5     
  Partials       78       78           
Flag Coverage Δ
python 79.75% <ø> (-0.01%) ⬇️
ruby-api 80.75% <ø> (+0.12%) ⬆️
ruby-backend 82.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"stored" field is not serialized correctly in redis

2 participants