Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2953 +/- ##
==========================================
+ Coverage 77.84% 78.45% +0.60%
==========================================
Files 471 673 +202
Lines 34693 55361 +20668
Branches 728 728
==========================================
+ Hits 27008 43435 +16427
- Misses 7607 11848 +4241
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| attr_accessor :converted_bit_size | ||
| # @return [Integer] The size in bits of the converted array value | ||
| attr_reader :converted_array_size | ||
| attr_accessor :converted_array_size |
There was a problem hiding this comment.
We're now setting these fields via CONVERTED_DATA so they must be accessor
| # Fall back to item's own data_type/bit_size when conversion doesn't specify | ||
| if converted_type is None: | ||
| converted_type = data_type | ||
| converted_bit_size = bit_size |
There was a problem hiding this comment.
This is another key change such that if you don't specify a CONVERTED_DATA field we use the existing type and bit size instead of going with varchar.
| summary: Defines the bit size, type, and array size of the converted data for a read conversion | ||
| description: This keyword is used in conjunction with DERIVED items to specify the bit size, type, and array size of the converted data. | ||
| If this keyword is not used, DERIVED items are stored as strings in the decommutated data. | ||
| since: 7.0.0 |
There was a problem hiding this comment.
Let's get this into 7.0.0
|
1 participant
closes #2822
If we like this I'll remove the converted_type and converted_bit_size from the various conversions