Skip to content

Allow TlmViewer to clear transient errors#2955

Merged
jmthomas merged 1 commit intomainfrom
screen_refresh
Mar 9, 2026
Merged

Allow TlmViewer to clear transient errors#2955
jmthomas merged 1 commit intomainfrom
screen_refresh

Conversation

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Mar 8, 2026

closes #2158


# Sort files so dependencies are uploaded before dependents:
# fonts first, then CSS, then index.html last (it triggers all other loads)
filenames = Dir.glob(gem_path + start_path + "**/*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path traversal attack possible - high severity
A malicious actor could control the location of this file, which may allow them to retrieve, write or delete files outside of the intended folder.

Show fix

Remediation: To address this, ensure that user-controlled variables in file paths are sanitized at least to not contain '..' or forward slashes.

Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info

else
[2, filename]
end
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the icons showing up as boxes issue. At least I wasn't able to reproduce after doing this.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.48%. Comparing base (0310dda) to head (c854cfe).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openc3/lib/openc3/models/tool_model.rb 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2955      +/-   ##
==========================================
- Coverage   78.48%   78.48%   -0.01%     
==========================================
  Files         673      673              
  Lines       55324    55333       +9     
  Branches      728      728              
==========================================
+ Hits        43423    43426       +3     
- Misses      11823    11829       +6     
  Partials       78       78              
Flag Coverage Δ
python 79.74% <ø> (-0.01%) ⬇️
ruby-api 80.60% <ø> (-0.03%) ⬇️
ruby-backend 82.15% <72.72%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2026

Copy link
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a docker system prune and launched this and everything loaded well!

@jmthomas jmthomas merged commit 74703b6 into main Mar 9, 2026
49 of 51 checks passed
@jmthomas jmthomas deleted the screen_refresh branch March 9, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

open screens automatically refresh upon plugin reload

2 participants