calibration: skip saved stages, persist shaper results, stream accel writes - #259
Draft
pdscomp wants to merge 1 commit into
Draft
calibration: skip saved stages, persist shaper results, stream accel writes#259pdscomp wants to merge 1 commit into
pdscomp wants to merge 1 commit into
Conversation
Contributor
Author
Feedback from @suchmememanyskill
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calibration: skip saved stages, persist shaper results, stream accel writes
Split from #252. Draft — commits not yet merged into this branch.
Why this PR
Three real bugs/behaviors in the calibration path: (1)
SAVE_CONFIGsilently did not persist shaper results set by Rusty/Classic viaSET_INPUT_SHAPER; (2) the boot/check flow re-ran every calibration stage even when saved results were current; (3) raw accelerometer CSV writes doubled peak memory by flattening batches into a full samples list first.Justification / measurements
TBD — isolated idle/calibration numbers with only this change set. (The +6.04 MiB
MemAvailableidle improvement reported in #252 was measured on the full series and is not attributable to this PR alone.)Verified behaviors:
input_shaper.pycmd_SET_INPUT_SHAPERnever calledconfigfile.set(), soSAVE_CONFIGsaw no dirty[input_shaper]section. Fixed.CALIBRATE_ALLdefaultsFORCE=1(full recalibration — old behavior preserved);CHECK_CALIBRATIONpassesFORCE=0to run only missing stages. Prompt text only asks operators to clear the chamber/bed when a stage actually requires it.write_to_file()streams CSV directly from message batches; no duplicate full-capture list in RAM.Commits (to be cherry-picked)
7e5533fcalibration: skip stages with saved results49d55d3kalico: persist input-shaper settings and stream raw accelerometer writesRisk / rollback
Low.
FORCE=1restores the historical always-full-recalibration behavior as default for the explicit macro; per-stage skips only affect the auto/check path. Rollback = revert macros + patches.