Klipper: Update hx711s with new architecture - #272
Merged
Conversation
Hopefully this fixes the `-1` readigs we were seeing in the previous driver now that we are reading the chips independently. This fix allows us to remove the `LOAD_CELL_CALIBRATE TARE=TRUE` hacks I added to `macros.cfg` as all probing moves call `LoadCellPrimitives.tare()` unconditionally. Also updating `sdo_pins` to `dout_pins` to be consistent with the datasheet and the hx71x driver.
jamesturton
temporarily deployed
to
approval-given
July 27, 2026 22:55 — with
GitHub Actions
Inactive
✅ Build ArtifactsBranch:
|
jamesturton
temporarily deployed
to
approval-given
July 29, 2026 00:56 — with
GitHub Actions
Inactive
✅ Build ArtifactsBranch:
|
jamesturton
temporarily deployed
to
approval-given
July 29, 2026 19:55 — with
GitHub Actions
Inactive
✅ Build ArtifactsBranch:
|
Collaborator
Author
|
Thank you @pdscomp @jaimbo @Atomique13 and @harrym for testing! |
jamesturton
temporarily deployed
to
approval-given
July 29, 2026 21:34 — with
GitHub Actions
Inactive
✅ Build ArtifactsBranch:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the
-1readigs we were seeing in the previous driver now that we are reading the chips independently. This fix allows us to remove theLOAD_CELL_CALIBRATE TARE=TRUEhacks I added tomacros.cfgas all probing moves callLoadCellPrimitives.tare()unconditionally.Also updating
sdo_pinstodout_pinsto be consistent with the datasheet and the hx71x driver.Link to kalico branch: https://github.com/OpenCentauri/kalico/commits/rpmsg-with-new-hx71x/