feat(event): refacto of eventInterceptor and EventFactory#58
Merged
Conversation
sidux
approved these changes
Dec 26, 2024
Wilkins
force-pushed
the
add_event_factory
branch
2 times, most recently
from
f975914 to
ecaf837
Compare
sidux
reviewed
Dec 26, 2024
Wilkins
force-pushed
the
add_event_factory
branch
from
ecaf837 to
8a5d04e
Compare
Wilkins
force-pushed
the
add_event_factory
branch
3 times, most recently
from
5533c11 to
4b7595a
Compare
|
Issued by Coverage Checker: |
sidux
reviewed
Jan 8, 2025
| $this->name = self::getName( | ||
| className: $class, | ||
| moment: $type, | ||
| transport: Transport::SYNC, |
Contributor
There was a problem hiding this comment.
we should pass the transport from the constructor which is set in the attribute
Wilkins
force-pushed
the
add_event_factory
branch
from
4b7595a to
de891e9
Compare
Wilkins
commented
Jan 22, 2025
| $this->eventDispatcher->dispatch( | ||
| $event, | ||
| $event->name . '.' . Transport::SYNC->value, | ||
| $event->name, |
Contributor
Author
There was a problem hiding this comment.
@sidux since we set the SYNC in the getName() I removed it from here otherwise we have a post.use_case.sync.sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.