bump thecodingmachine safe to 3

[NicolasMugnier]

• chore(dependencies): updates
• chore(phpstan): fix errors
• fix(tests): update snapshots and fix setOptions unknown key handling
• fix(tests): fix MT_RAND_PHP and float modulo PHP 8.4 deprecations
• fix(ArrayFaker): re-index array after array_unique to avoid associative keys
• fix(deps): patch cebe/php-openapi for PHP 8.4 implicit nullable deprecations

[Copilot]

Pull request overview

Updates project dependencies (notably thecodingmachine/safe v3 and cebe/php-openapi v1.8) and adjusts faker/test logic to address PHPStan findings and PHP 8.4 deprecations, with snapshots refreshed accordingly.

Changes:

• Bump runtime + dev dependencies and add a composer patch to silence PHP 8.4 implicit-nullable deprecations in cebe/php-openapi.
• Refine faker generation logic (enum/format/pattern checks, array uniqueItems reindexing, safer schema/property handling).
• Update tests and snapshots for RNG/behavior changes and PHP 8.4 deprecations.

Reviewed changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
composer.json	Bumps dependencies; adds composer-patches configuration for cebe/php-openapi PHP 8.4 deprecations.
patches/cebe-php-openapi-php84-nullable.patch	Patch to add explicit nullable type hints to avoid PHP 8.4 implicit-nullable deprecations.
src/OpenAPIFaker.php	Tightens setOptions() to only apply known keys via array_intersect_key + match.
src/SchemaFaker/ArrayFaker.php	Reindexes array_unique() output via array_values(); adjusts uniqueness comparison behavior.
src/SchemaFaker/BooleanFaker.php	Treats empty enums as “no enum” for generation decisions.
src/SchemaFaker/NumberFaker.php	Treats empty enums as “no enum” for generation decisions.
src/SchemaFaker/ObjectFaker.php	Skips non-Schema properties before applying readOnly/writeOnly filtering.
src/SchemaFaker/SchemaFaker.php	Uses !empty($schema->properties) when deciding object generation fallback.
src/SchemaFaker/StringFaker.php	Switches enum/format/pattern checks from !== null to !empty().
src/Utils/RegexUtils.php	Uses Safe\preg_replace_callback and removes unnecessary null-coalescing on $regex.
tests/Integration/E2ETest.php	Avoids risky tests via addToAssertionCount; adds instanceof Schema guard before schema access.
tests/Integration/OpenAPIFakerTest.php	Replaces instance assertions with addToAssertionCount; reformats @testWith; removes duplicate assertion.
tests/Unit/UnitTestCase.php	Adjusts seeding to avoid MT_RAND_PHP usage.
tests/Unit/SchemaFaker/ArrayFakerTest.php	Drops Safe\sort, removes MT_RAND_PHP usage in seeding, updates unique-element test.
tests/Unit/SchemaFaker/NumberFakerTest.php	Avoids float % deprecation by casting before modulo in a test.
tests/Unit/SchemaFaker/ObjectFakerTest.php	Removes redundant assertIsArray assertions; snapshots updated.
tests/Unit/SchemaFaker/StaticObjectFakerTest.php	Removes redundant assertIsArray assertions.
tests/Unit/SchemaFaker/StringFakerTest.php	Uses sprintf instead of Safe\sprintf.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_generate_items__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_handle_both_min_and_max_items__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_handle_max_items__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_handle_min_items__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_override_both_minimum_and_maximum_items_with_options__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_override_maximum_items_with_option__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_override_minimum_if_its_greater_than_maximum__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_can_override_minimum_items_with_option__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_handles_nested_arrays__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_will_not_override_maximum_items_with_option_if_option_is_greater__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_will_not_override_minimum_items_with_option_if_option_is_smaller__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ArrayFakerTest__it_will_use_minimum_plus_15_as_max_items_if_its_not_given__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_generate_a_integer__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_generate_a_number__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_generate_elements_from_enum__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_both_minimum_and_maximum_keyword__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_exclusive_maximum_keyword__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_exclusive_minimum_keyword__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_integer_int32_format__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_integer_int64_format__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_maximum_keyword__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_minimum_keyword__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_number_double_format__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/NumberFakerTest__it_can_handle_number_float_format__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_can_fake_all_properties_if_always_fake_optionals_option_is_set__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_can_generate_nested_objects__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_can_generate_simple_object__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_does_not_inlcude_readonly_properties_when_type_is_request__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_does_not_inlcude_writeonly_properties_when_type_is_response__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ObjectFakerTest__it_includes_required_properties_all_the_time__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/RequestFakerTest__it_will_mock_the_request__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/ResponseFakerTest__it_will_mock_the_response__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__allof_merge__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__another_merge_test__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_can_choose_one_schema_from_one_of__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_can_merge_all_of_with_other_properties__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_can_merge_schemas_from_all_of__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_can_recursively_merge_of_constraints__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_will_merge_all_of_with_existing_schema__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/SchemaFakerTest__it_will_merge_one_of_with_existing_schema__1.json	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_generate_elements_from_enum__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_generate_single_string__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_binary_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_byte_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_email_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_hostname_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_ipv4_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_ipv6_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_max_length__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_min_length__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_password_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_patterns__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_uri_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_can_handle_uuid_format__1.txt	Snapshot refresh for updated RNG/output.
tests/Unit/SchemaFaker/__snapshots__/StringFakerTest__it_will_return_a_string_if_unknown_format_is_given__1.txt	Snapshot refresh for updated RNG/output.

Comments suppressed due to low confidence (2)

src/SchemaFaker/ArrayFaker.php:18

• These imports/constants are now unused (is_array, SORT_STRING) after switching to SORT_REGULAR. Removing them will avoid unused-import noise in static analysis.

use function is_array;

use const SORT_REGULAR;
use const SORT_STRING;

src/SchemaFaker/ArrayFaker.php:63

• array_unique() cannot increase the number of elements, so count($uniqueData) > count($fakeData) is unreachable. If the intent is to skip work when nothing changed, compare with === (no duplicates) or just remove this branch and only reindex when duplicates were removed.

            $uniqueData = array_unique($fakeData, SORT_REGULAR);

            if (count($uniqueData) > count($fakeData)) {
                continue;
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 73 out of 73 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (2)

src/SchemaFaker/ArrayFaker.php:18

• ArrayFaker no longer uses is_array() or SORT_STRING, so the corresponding imports/constants are now unused. Please remove them (or reintroduce usage) to avoid dead imports and keep static analysis clean.

use function count;
use function is_array;

use const SORT_REGULAR;
use const SORT_STRING;

src/SchemaFaker/ArrayFaker.php:63

• This uniqueness check is logically impossible: count($uniqueData) can never be greater than count($fakeData) right after array_unique(). The condition is effectively dead code; it can be removed, or (if the intent was to detect duplicates) changed to the correct comparison.

            $uniqueData = array_unique($fakeData, SORT_REGULAR);

            if (count($uniqueData) > count($fakeData)) {
                continue;
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.