Add Blacksmith Switch build and release CI - #29
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reached
Next review available in: 53 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR adds Switch release automation. It validates versions, builds dependencies, packages the NRO and supporting files, uploads artifacts, and publishes GitHub releases on successful ChangesSwitch release pipeline
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant VersionScripts
participant SwitchBuild
participant package-release.sh
participant GitHubRelease
GitHubActions->>VersionScripts: Resolve release version
GitHubActions->>SwitchBuild: Build SwitchNOW.nro
SwitchBuild->>package-release.sh: Package versioned release files
package-release.sh->>GitHubActions: Upload NRO and ZIP artifacts
GitHubActions->>GitHubRelease: Publish release assets on main push
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/switch-release.yml:
- Line 22: Update the workflow’s actionlint configuration to recognize the
Blacksmith runner labels used by runs-on, including blacksmith-4vcpu-ubuntu-2404
and the other Blacksmith label in this workflow. Ensure CI loads this
runner-label configuration when validating the workflow.
- Around line 68-78: Pin the release-job actions to the specified immutable
commit SHAs: update actions/download-artifact in the “Download build artifact”
step to d3f86a106a0bac45b974a628896c90dbdf5c8093 and softprops/action-gh-release
in the “Publish release with generated notes” step to
3bb12739c298aeb8a4eeaf626c5b8d85266b0e65, preserving their existing
configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6da00c85-b18e-434e-97bd-bc3493385def
📒 Files selected for processing (6)
.github/workflows/switch-release.ymlCMakeLists.txtREADME.mdscripts/build-switch-msys2.shscripts/package-release.shscripts/read-version.sh
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/switch-release.yml:
- Around line 42-43: Use app/src/app_version.hpp as the sole runtime version
source: update app/src/app_version.hpp lines 3-10 and synchronize the required
CMake, packaging, README, and installer metadata. In
.github/workflows/switch-release.yml lines 42-43, resolve the checked-in version
via scripts/read-version.sh and fail unless the selected release tag matches it;
use that validated value for build/package steps at lines 68-72 and release
tag/name publication at lines 102-104. In CMakeLists.txt lines 12-16 and 75-80,
derive or validate metadata from the canonical header and prevent any
independently generated workflow value from replacing the runtime version.
- Line 53: Update the workflow’s container image reference from the mutable
devkitA64 tag to the specified sha256 digest, preserving the existing
devkitpro/devkita64 image.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 28e54197-b57e-4a7e-9a7b-247ea0a34ce4
📒 Files selected for processing (7)
.github/workflows/switch-release.ymlCMakeLists.txtREADME.mdapp/src/app_version.hppscripts/build-switch-msys2.shscripts/next-release-version.shscripts/read-version.sh
🚧 Files skipped from review as they are similar to previous changes (3)
- scripts/read-version.sh
- scripts/build-switch-msys2.sh
- README.md
1 participant
Summary
mainbuild to GitHub ReleasesVerification
v0.0.6resolved to0.0.7; an existing-release retry resolved back to its original versiondevkitpro/devkita64:20260219build producedSwitchNOW-0.0.7.nro0.0.7, with no stale0.0.6runtime versionunzip -tand contained the expected SD-card layoutactionlintwith the documented Blacksmith custom runner labels allowedgit diff --checkSummary by CodeRabbit
New Features
Improvements
Documentation