Fix redundant updates in MappingHome by restricting componentDidUpdate#27
Open
PratikshaJ-16 wants to merge 2 commits intoOpenConceptLab:masterfrom
Open
Fix redundant updates in MappingHome by restricting componentDidUpdate#27PratikshaJ-16 wants to merge 2 commits intoOpenConceptLab:masterfrom
PratikshaJ-16 wants to merge 2 commits intoOpenConceptLab:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the behavior of
componentDidUpdateinMappingHome.jsx.Changes:
refreshDataByURL()is now triggered only whenlocation.pathnamechanges.2.
highlightFromSearch()runs only whensearchMetachanges.Why:
Previously,
highlightFromSearch()was executed on every update, which could lead to unnecessary re-renders and redundant operations.This change ensures updates occur only when relevant props change, improving performance and stability.