Skip to content

test(api): baseURL path-prefix coverage + ContentCache indent fix #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BunsDev merged 1 commit into from
May 30, 2026
Merged

test(api): baseURL path-prefix coverage + ContentCache indent fix #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Sources/FeedbackKit/Cache/ContentCache.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import Foundation
public struct ContentCache: Sendable {
private let directory: URL

public init(directory: URL = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask)[0]
.appendingPathComponent("FeedbackKit")) {
self.directory = directory
try? FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: nil)
}
public init(directory: URL = FileManager.default.urls(for: .cachesDirectory, in: .userDomainMask)[0]
.appendingPathComponent("FeedbackKit")) {
self.directory = directory
try? FileManager.default.createDirectory(at: directory, withIntermediateDirectories: true, attributes: nil)
}

public func save<T: Encodable>(_ value: T, as key: String) throws {
let data = try Self.encoder.encode(value)
Expand Down
16 changes: 16 additions & 0 deletions Tests/FeedbackKitTests/HTTPFeedbackAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,20 @@ final class HTTPFeedbackAPITests: XCTestCase {
XCTAssertEqual(error as? APIError, .unauthorized)
}
}

// A baseURL with a path prefix (e.g. https://host/feedback) must be preserved
// when building request URLs, not dropped — guards the request(path:) path-join.
func testListPostsPreservesBaseURLPathPrefix() async throws {
let cfg = URLSessionConfiguration.ephemeral
cfg.protocolClasses = [StubURLProtocol.self]
let session = URLSession(configuration: cfg)
let api = HTTPFeedbackAPI(baseURL: URL(string: "https://fb.example.com/feedback")!,
session: session, tokenProvider: { nil })
StubURLProtocol.handler = { req in
XCTAssertEqual(req.url?.path, "/feedback/api/public/v1/posts")
let body = #"{"data":[],"meta":{"pagination":{"cursor":null,"hasMore":false}}}"#
return (HTTPURLResponse(url: req.url!, statusCode: 200, httpVersion: nil, headerFields: nil)!, Data(body.utf8))
}
_ = try await api.listPosts(boardId: nil, sort: .newest, cursor: nil)
}
}
Loading