feat: support external File Provider storage on macOS - #6
Open
OpenCow42 wants to merge 9 commits into
Open
Conversation
OpenCow42
force-pushed
the
codex/external-file-provider-storage
branch
from
July 26, 2026 10:08
3a94e8a to
69e54fd
Compare
OpenCow42
marked this pull request as ready for review
July 26, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSFileProviderDomaininitializer on macOS and gate every choice throughcheckDomainsCanBeStoredOnVolume(at:)Validation
git diff --check main...HEADpassedReview notes
This is a draft until the physical external-drive matrix in
doc/TESTING_AND_DEVELOPMENT.mdis exercised with eligible encrypted APFS media, including unplug/replug, launch-while-missing, move rollback, and logout/removal behavior.The broad legacy macOS test target still has a pre-existing networking-test isolation problem around the shared
KDriveJSONRequestCapturingURLProtocol: the create-upload operation can stall, and parallel runs can race the lazy-download capture. The new feature suites pass cleanly and do not use that capture.Apple references: