chore(deps-dev): bump electron from 35.7.5 to 41.0.3#68
chore(deps-dev): bump electron from 35.7.5 to 41.0.3#68dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
6b4cb98 to
9cc4fc3
Compare
2bed935 to
8462e76
Compare
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
There was a problem hiding this comment.
Findings
- [Major] Electron 41 drops macOS 11 / Big Sur support, but this PR only bumps the dependency. The repo still advertises generic macOS support and the mac build config does not declare a minimum OS version, so Big Sur users can receive a build that no longer launches. Evidence
package.json:102,README_zh.md:21,README_zh.md:30,electron-builder.yml:81. Not found in repo/docs: any macOS 12+ requirement.
Summary
Review mode: initial
1 major issue found.
Testing
npm run typecheckfailed in the current checkout withtsconfig.jsondeprecation error (baseUrlwithoutignoreDeprecations), which does not appear related to this PR.npm run test -- --run src/tests/pre-build-check.test.ts src/tests/preflight.test.tscould not run becausevitestis not installed in this environment.
Open Cowork Bot
| "autoprefixer": "^10.4.27", | ||
| "electron": "^35.7.5", | ||
| "electron": "^41.1.1", | ||
| "electron-builder": "^26.8.1", |
There was a problem hiding this comment.
[MAJOR] Electron 41 drops macOS 11 / Big Sur support, so this version bump becomes a silent runtime regression for existing macOS users unless the project raises its published minimum OS in the same PR. The repo still advertises generic macOS support (README_zh.md:21, README_zh.md:30), and the packager does not declare a minimum system version (electron-builder.yml:81).
Suggested fix:
# electron-builder.yml
mac:
minimumSystemVersion: "12.0.0"# README_zh.md
| **macOS 12+** (Apple Silicon) | `.dmg` |8462e76 to
e002081
Compare
Bumps [electron](https://github.com/electron/electron) from 35.7.5 to 41.0.3. - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v35.7.5...v41.0.3) --- updated-dependencies: - dependency-name: electron dependency-version: 41.0.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e002081 to
d3e8565
Compare
|
Looks like electron is no longer being updated by Dependabot, so this is no longer needed. |
Bumps electron from 35.7.5 to 41.0.3.
Release notes
Sourced from electron's releases.
... (truncated)
Commits
44bc2c8fix: user resizable transparent windows on win32 (#50298)4e9e733test: fix esm issue in node-spec-runner (#50295)cd88382fix: add ASAR support to additional copy methods (#50286)105c559docs: update the example ofwebContents.setWindowOpenHandlerto cla… (#50293)90b3a23build: remove redundant bits of ncrypto node patch (#50279)21f9474chore: bump chromium to 146.0.7680.80 (41-x-y) (#50262)c3e397efix: prefer browser runtime over node in DevTools HostRuntime detection (#50276)d84dca2build: skip archiving patch conflict fix artifact (#50257)bb20d0cdocs: point pull requests guide to build tools (#50253)c66fc55chore: bump chromium to 146.0.7680.76 (41-x-y) (#50244)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)