FEWS-33815: Exchange items for start and end dates of control file #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The IExchangeItem created has exactly two times (start and end date time). These are exposed as Modified Julian Dates with the hours as the decimal part of the double values used. |
erikpelgrim
requested changes
Jan 29, 2026
Contributor
erikpelgrim
left a comment
erikpelgrim
left a comment
There was a problem hiding this comment.
instead of 1 exchange item with both start and end time, we need 2 separate exchange items, 1 for start time and 1 for end time. The id's can be as simple as "start_time" & "end_time"
You can use the DoubleExchangeItem class, so no need for ControlFileExchangeItem
erikpelgrim
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.