Perf/schedulable service object array#70
Merged
bm01 merged 7 commits intoOpenDAoC:masterfrom Mar 18, 2026
Merged
Conversation
Takes an array of start indices, and processes lists of lists as if they were a single contiguous list. Changed method signatures to take IReadOnlyList to allow arrays and make it clearer that they aren't modified. I would have preferred ReadOnlySpan but it isn't compatible with WorkProcessor.
Changed signature of ExecuteForEach to take IReadOnlyList.
* See comment in ServiceObjectStore. * Changed how items are returned. UpdateAndGetAll is now UpdateAndGetView and returns a ServiceObjectView. This readonly struct is a bridge between the two fundamentally different ShardedServiceObjectArray and ServiceObjectArray. The ExecuteForEach helper method dispatches to the correct one in GameLoop. * Updated ABrain to replace ServiceObjectId.IsPendingRemoval usage. * Updated GameNPC to replace ServiceObjectId.IsSet usage. * Updated every game loop service to accomodate for this change (keeping track oflastValidIndex for example is no longer needed).
* Added Schedule. * Made NextThinkTick setter private. * Updated StandardMobBrain, CrowdControlECSEffect, NpcService, StandardMobState_IDLE to call Schedule. * Updated ServiceObjectStore to process ABrain type via ShardedServiceObjectArray.
* Updated ServiceObjectStore to process ECSGameTimer type via ShardedServiceObjectArray.
* Added GetNextTick. * Updated ECSGameAbilityEffect and ECSGameSpellEffect to override GetNextTick. * Updated EffectService and EffectListComponent to call Schedule. * Updated ServiceObjectStore to process ECSGameEffect type via ShardedServiceObjectArray.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.