[PATCH v1] abi: time: change odp_time_t abi type to uint64_t#2343
Open
MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
Open
[PATCH v1] abi: time: change odp_time_t abi type to uint64_t#2343MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
Change odp_time_t ABI type from struct to uint64_t, which makes the time API implementation simpler. The change triggered a couple false positive 'maybe-uninitialized' warnings. Signed-off-by: Matias Elo <matias.elo@nokia.com>
odpbuild
changed the title
| **/ | ||
|
|
||
| typedef struct odp_time_s odp_time_t; | ||
| typedef uint64_t odp_time_t; |
Collaborator
There was a problem hiding this comment.
The struct wrapped uint64_t has the benefit that it better enforces proper API usage as variables of odp_time_t cannot be used directly in time calculation and comparisons. It also makes odp_time_t type unique. I wonder if the implementation simplifications are big enough to outweigh the reduction of API safety.
Collaborator
Author
There was a problem hiding this comment.
Perhaps the biggest benefit of changing this would be that it enables applications to compare odp_time_t values directly to ODP_TIME_NULL. Currently, odp_time_t is a bit of an exception compared to other ODP handles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change odp_time_t ABI type from struct to uint64_t, which makes the time API implementation simpler. The change triggered a couple false positive 'maybe-uninitialized' warnings.