[PATCH v2] linux-gen: parse: fix parsing of non-first IPv4 fragments#2345
Open
MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
Open
[PATCH v2] linux-gen: parse: fix parsing of non-first IPv4 fragments#2345MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
MatiasElo wants to merge 1 commit intoOpenDataPlane:masterfrom
Conversation
JannePeltonen
approved these changes
Apr 30, 2026
Non-first IPv4 fragments do not include a complete L4 header. The parser was unconditionally parsing TCP/UDP/SCTP headers for all fragments, causing spurious errors. This in turn caused odp_pktio_stats() to report invalid 'in_errors' for every non-first fragment received. Fix this by stopping parsing after L3 for non-first IPv4 fragments. Also, make _odp_packet_l4_chksum() handling of fragmented packets more robust and change the if clauses to be exclusive. Closes: OpenDataPlane#2342 Signed-off-by: Matias Elo <matias.elo@nokia.com> Reviewed-by: Janne Peltonen <janne.peltonen@nokia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.