Update extension logic including dynamic pages and icon fonts#82
Open
Herobone wants to merge 9 commits intoOpenDyslexic:mainfrom
Open
Update extension logic including dynamic pages and icon fonts#82Herobone wants to merge 9 commits intoOpenDyslexic:mainfrom
Herobone wants to merge 9 commits intoOpenDyslexic:mainfrom
Conversation
Member
|
Hey, Thanks so much for taking the time to put this pull request together, I really appreciate the effort! I’ll go through it in detail this weekend. Since the extension has a large user base, we need to be extra careful when bumping packages to make sure everything stays stable. I’m looking forward to testing this out and reviewing your changes. For future reference, when making bigger changes like this, it’s usually best to break them down into smaller, multiple pull requests. That makes them easier to review and test incrementally. Thanks again for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the OpenDyslexic extension, focusing on more robust font application, cleaner state management, and improved manifest configuration for both Chrome and Edge. The changes streamline CSS handling, enhance reliability when applying fonts to dynamic pages, and update extension metadata for future releases.
Font Application & CSS Improvements
engine.jsto use a centralized state object, ensuring more reliable font switching and injection, especially on dynamic pages; added MutationObserver logic to handle late body insertion and flush pending font changes. [1] [2]opendyslexic.cssto reduce duplication and ensure correct inheritance, making it easier to maintain and improving performance. [1] [2] [3]unicode-rangefor all font-face declarations to support a broader character set. [1] [2] [3] [4] [5]Extension State & Badge Updates
updateBadgefunction, improving clarity and reliability of badge state changes; updated background script to only query storage for changed values and streamlined tab messaging. [1] [2] [3]Manifest & Configuration Updates
2025.9.14, addedrun_at: document_startfor content scripts to ensure early font injection, and restructured manifest formatting for clarity and future maintainability. [1] [2] [3] [4] [5]These changes collectively improve extension reliability, maintainability, and user experience.
Fixes #49 and #67