Skip to content

feat: add optional manufacturer field to brand schema #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jpapiez wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: add optional manufacturer field to brand schema #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1366d5b
feat: add optional manufacturer field to brand schema
jpapiez Feb 28, 2026
084e2af
Update data/smartprint/brand.json
jpapiez Feb 28, 2026
228247a
fix: add type constraint to id definition in brand schema
jpapiez Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion data/easyprint/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "EasyPrint",
"website": "https://primacreator.com/",
"logo": "logo.png",
"origin": "SW"
"origin": "SW",
"manufacturer": "primacreator"
}
3 changes: 2 additions & 1 deletion data/fiberon/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "Fiberon",
"website": "https://fiberon.polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/jessie/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "Jessie",
"website": "https://www.printedsolid.com/",
"logo": "logo.png",
"origin": "US"
"origin": "US",
"manufacturer": "printedsolid"
}
4 changes: 2 additions & 2 deletions data/panchroma/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"name": "Panchroma",
"website": "https://polymaker.com/panchroma/",
"logo": "logo.png",
"origin": "CN"
}
"origin": "CN",
"manufacturer": "polymaker"
3 changes: 2 additions & 1 deletion data/polyflex/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PolyFlex",
"website": "https://polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/polylite/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PolyLite",
"website": "https://polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/polymax/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PolyMax",
"website": "https://polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/polymide/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PolyMide",
"website": "https://polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/polysonic/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PolySonic",
"website": "https://polymaker.com/",
"logo": "logo.svg",
"origin": "CN"
"origin": "CN",
"manufacturer": "polymaker"
}
3 changes: 2 additions & 1 deletion data/primaselect/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PrimaSelect",
"website": "https://primacreator.com/",
"logo": "logo.png",
"origin": "SW"
"origin": "SW",
"manufacturer": "primacreator"
}
3 changes: 2 additions & 1 deletion data/primavalue/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "PrimaValue",
"website": "https://primacreator.com/",
"logo": "logo.png",
"origin": "SW"
"origin": "SW",
"manufacturer": "primacreator"
}
3 changes: 2 additions & 1 deletion data/professional_lab/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "Professional LAB",
"website": "https://print-imagine.com/",
"logo": "logo.png",
"origin": "PL"
"origin": "PL",
"manufacturer": "smartprint"
}
3 changes: 2 additions & 1 deletion data/the_filament/brand.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
"name": "The Filament",
"website": "https://spectrumfilaments.com/en/brand/the-filament-en/",
"logo": "logo.png",
"origin": "PL"
"origin": "PL",
"manufacturer": "spectrum"
}
Empty file modified ofd.sh
100644 → 100755
View file
Open in desktop
Empty file.
8 changes: 7 additions & 1 deletion schemas/brand_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
},
"id": {
"maxLength": 1000,
"pattern": "^[a-z0-9+]+(_[a-z0-9+]+)*$"
"pattern": "^[a-z0-9+]+(_[a-z0-9+]+)*$",
"type": "string"
},
"logo": {
"pattern": "^logo\\.(png|jpg|svg)$"
Expand Down Expand Up @@ -46,6 +47,11 @@
"type": "string",
"description": "The source of the data, like another DB or company",
"$ref": "#/definitions/string_limit"
},
"manufacturer": {
"type": "string",
"description": "The brand id of the parent manufacturer, for product lines sold under a different name",
"$ref": "#/definitions/id"
}
},
"required": [
Expand Down