Fix CMAP palette bounds in Amiga ILBM decoder#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CMAPchunks into the fixed 256-entrysImage::mPalettewhich could be triggered by crafted/oversized CMAP chunks in attacker-controlled assets.Description
if (i < 256)) around writes toResult.mPalette[i]inSource/Amiga/Graphics_Amiga.cpp::DecodeIFFwhile continuing to consume CMAP bytes so parsing behavior for valid assets is preserved.Testing
git diff -- Source/Amiga/Graphics_Amiga.cpp && git status --shortto verify the change and it reported the expected diff; the command succeeded.git add Source/Amiga/Graphics_Amiga.cpp && git commit -m "Fix CMAP palette bounds in Amiga ILBM decoder"and the commit succeeded.nl -ba Source/Amiga/Graphics_Amiga.cpp | sed -n '600,635p'to confirm the bounds check is present and that command succeeded.Codex Task