Fix heap corruption risk in Amiga ILBM decoder#117
Closed
segrax wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cGraphics_Amiga::DecodeIFF(const std::string&)trusted file-declared FORM/chunk sizes, BMHD dimensions, plane counts, and RLE packet lengths, which allowed crafted local.lbmassets to cause out-of-bounds reads/writes and heap corruption.Description
DataBegin/DataEnd,ReadAvailable, andSkipBytes, and clamped the declaredFORMsize to the actual buffer length.BMHDchunk size and ensured a valid BMHD header is present before decodingBODY, and advanced parsing using padded chunk lengths to avoid trusting chunk size fields.BODYRLE decoding to compute safeWidth/Height/Planes, use overflow-checked allocation (assignwith computedDataSize), validate per-packet availability, clamp run lengths to remaining row width, and usememcpy/memsetfor bounded copies.CMAPby checkingi < Result.mPalette.size()and ensured chunk bytes are consumed correctly; all changes are contained toSource/Amiga/Graphics_Amiga.cppand do not change public APIs.Testing
git diff/nl -bato review the modifiedDecodeIFFimplementation and confirmed the patch was committed (git commit), all of which succeeded.sdl2-config: not found/ missingSDL.h), so the ASan harness was not re-run here.Source/Amiga/Graphics_Amiga.cpp.Codex Task