Guard PC resource buffer accesses against truncated DAT files#118
Merged
segrax merged 1 commit intoMay 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
std::vector<uint8>buffers replace legacy fixed-size buffers while code still reads/writes fixed offsets.Description
sImage::LoadPaletteso it returns early ifpFrom+ (pCount* 3) would exceed the backing buffer size, preventing palette reads past the end of the file buffer.min(0xA000, mImageHillSprites.mData->size())so writes do not overflow whenhill.datis truncated.Source/Graphics.hppandSource/PC/Graphics_PC.cppand preserve behavior for correctly-sized original assets.Testing
git diff,nl -baexcerpts) to verify the patch is applied and the modified lines appear as expected, andgit commitsucceeded for the change.make_prto record the change.sdl2-config/SDL.h), so full ASan verification could not be completed in this container.Codex Task