Add OGWedge primitive and three.js Wedge shape support#6
Merged
aka-blackboots merged 2 commits intoMar 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
OGWedgewithcenter,width,height, anddepth, BRep construction, triangulation-based geometry serialization, and outline serialization (main/opengeometry/src/primitives/wedge.rs).pub mod wedgeinmain/opengeometry/src/lib.rs).add_wedge_to_scene_internaland wasm-bindgen bindingsaddWedgeToSceneandaddWedgeToCurrentSceneinmain/opengeometry/src/scenegraph.rsso wedges can be added to scenes like other primitives.pdf_primitives_allto construct a wedge and export its projected PDF (*_wedge.pdf), and add aWedgewrapper inopengeometry-threeplus export it from the shapes index (main/opengeometry-three/src/shapes/wedge.tsandmain/opengeometry-three/src/shapes/index.ts).AI-DOCs/opengeometry/2026-03-01-wedge-shape-support.mddescribing changes and local test instructions.Testing
cd main/opengeometry && cargo fmtand it completed successfully.cd main/opengeometry && cargo checkand it completed successfully.cd main/opengeometry && cargo testand all unit tests passed.cd main/opengeometry && cargo run --example pdf_primitives_all -- wedge_demowhich completed and generated the wedge example PDF (e.g.wedge_demo_wedge.pdf).npm run build-corefailed in this environment becausewasm-packis not installed, andnpm run build-threefailed becausemain/opengeometry/pkg/opengeometry(wasm bindings) is not present untilwasm-packproduces them; these are environment limitations rather than functional regressions.npm run lint:checkreported pre-existing lint issues in the three package (main/opengeometry-three/src/utils/event.tsand a console usage warning inpolygon.ts) which are unrelated to the wedge code.Codex Task