Add voxel-constrained boolean operations to kernel and Three.js adapter#8
Closed
aka-blackboots wants to merge 1 commit into
Closed
Add voxel-constrained boolean operations to kernel and Three.js adapter#8aka-blackboots wants to merge 1 commit into
aka-blackboots wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BRepoutput and be invoked from JS/Three consumers.voxel_size).@opengeometry/kernel-threeadapter so examples and downstream code can consume it immediately.Description
main/opengeometry/src/operations/boolean.rsthat exposesBooleanOperationandOGBooleanResultvia wasm-bindgen and accepts serialized BReps as inputs.main/opengeometry/src/lib.rswithpub mod boolean;.BooleanMeshinmain/opengeometry-three/src/operations/boolean.tsplus an operations index and exported it frommain/opengeometry-three/index.tsso consumers canimport { BooleanMesh } from '@opengeometry/kernel-three'.main/opengeometry-three/examples-vite/src/pages/operations-boolean.tsand HTML entry) demonstratingunion,intersection, anddifferencewith avoxelSizeslider, and included an implementation/handoff doc atAI-DOCs/opengeometry/2026-03-04-boolean-operations-implementation.mdexplaining approach, caveats, and testing instructions.Testing
cargo fmtinmain/opengeometryand it completed successfully.cargo test --manifest-path main/opengeometry/Cargo.tomland the kernel unit tests (including the new boolean tests) passed.npx eslint main/opengeometry-three/src/operations/boolean.tsand the new file passes linting.npm run lint:checkfailed due to pre-existing unrelated TypeScript lint errors in other files (main/opengeometry-three/src/utils/event.ts), not introduced by these changes.npm run build-example-threefailed in this environment because the wasm packagemain/opengeometry/pkg/opengeometrywas not generated here, so the example build could not complete.Codex Task