Enable ESLint rule vue/no-use-v-if-with-v-for#396
Merged
Conversation
annehaley
approved these changes
Jun 5, 2026
Collaborator
annehaley
left a comment
annehaley
left a comment
There was a problem hiding this comment.
I was able to test the filter features locally and confirmed the behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://eslint.vuejs.org/rules/no-use-v-if-with-v-for
The change here satisfies the rule, but also removes a somewhat awkward pattern where a
v-forwas being abused to set a temporary variable. The core issue the lack of av-letsyntax for setting scoped template variables (which is a requested feature). However, in removing thev-forabuse, we are forced to callfindVectorProperty(filter)several times in the rendered template, which looks bad, but should be quite cheap (particularly in comparison to the amount of Javascript that's ultimately run in the Vue engine to render any parts of a template).