This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Change Fixnums to Integers#6
Open
aclimatt wants to merge 412 commits into
Open
Conversation
… library since 2009
… point in calling it explicitly
…he global namespace
…l searches with exact root searches in read_shared_strings and read_cells. I also had to remove namespaces from that docs cause xpath was not findind the nodes. Conflicts: lib/roo/excelx.rb
… 'bad' encoding in Excel files (this is to give woto credit for the original fix 2548b8c03615cfd15f9723) Conflicts: lib/roo/excel.rb
Conflicts: test/test_roo.rb
Tests clean up
GenericSpreadSheet#set changed sightly its behaviour, since now it prevents updating the spreadsheet when #set raises an ArgumentError
Refactor Google spreadsheet to comply with GenericSpreadSheet class protocol for setting cell's values
Clear warning when running tests
Refactor GenericSpreadSheet
… implementation, #_set_value
Signed-off-by: t.pickett66 <t.pickett66@gmail.com>
Signed-off-by: t.pickett66 <t.pickett66@gmail.com>
…ome nokogiri hacks to remedy.
… prints from exploding, fixed xlsx cell parse timing.
…as it was in place for this purpose.
Added massive improvements to xls parsing.
DATA-157: Data manager should support CSV & XLS file formats for transaction uploads
Fix parsing bug causing NoMethodError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Ruby 2.4.5 by updating Fixnums to Integers.