[Feat] Open Account in a New Tab + Reusable ConfirmDialog Component#42
Merged
maneeshaxyz merged 1 commit intoJul 15, 2026
Conversation
Aravinda-HWK
self-requested a review
July 12, 2026 06:13
saknarajapakshe
force-pushed
the
33-feat-account-context-multi-tab-plumbing
branch
from
July 13, 2026 03:41
0726e70 to
98fa3de
Compare
… account switching
saknarajapakshe
force-pushed
the
33-feat-account-context-multi-tab-plumbing
branch
from
July 15, 2026 03:45
98fa3de to
633e500
Compare
saknarajapakshe
changed the title
saknarajapakshe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AccountContext.addAccountno longer auto-switches the current tab — callers decide whether to switch.AccountContextnow checks?account=<id>in the URL before falling back to the stored active account, so a freshly opened tab knows which account it belongs to.src/nonview/core/openAccountInNewTab.ts, usingimport.meta.env.BASE_URL(not a bare"/") since the app is served under/quicksilver/.src/view/atoms/ConfirmDialog.tsx, a reusable confirm dialog (fullScreen on mobile, centered on desktop — same pattern asComposeDialog), for later use by "Sign out of all accounts?" and "Remove this account?".Closes #33
Test plan (After fixing #23 completely)
?account=<id>in the URL, reload, and confirm it still shows that account.ConfirmDialogrenders full-screen on mobile widths and centered on desktop.