Skip to content

Migrate Chronicle Map tests to JUnit 5 #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peter-lawrey wants to merge 8 commits into
base: develop
Choose a base branch
from

Checkpoint current changes

cd35756
Select commit
Loading
Failed to load commit list.
Open

Migrate Chronicle Map tests to JUnit 5 #588

Checkpoint current changes
cd35756
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 30, 2026 in 38s

Quality Gate passed

Issues
125 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 29 in src/test/java/net/openhft/chronicle/map/BuildVersionTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIjcmxdebns9x5wN&open=AZ0ppIjcmxdebns9x5wN&pullRequest=588

Check warning on line 85 in src/test/java/net/openhft/chronicle/map/locks/DirtyReadOffender_WriterReaderTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffFvKhSD72ysnLwpL&open=AZ0ffFvKhSD72ysnLwpL&pullRequest=588

Check warning on line 52 in src/test/java/net/openhft/chronicle/map/EntryCountMapTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 29 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIo8mxdebns9x5wX&open=AZ0ppIo8mxdebns9x5wX&pullRequest=588

Check failure on line 35 in src/test/java/net/openhft/chronicle/map/locks/WriterToo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this assertion. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffFuJhSD72ysnLwpA&open=AZ0ffFuJhSD72ysnLwpA&pullRequest=588

Check failure on line 19 in src/test/java/net/openhft/chronicle/map/BitUnitTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIq4mxdebns9x5wa&open=AZ0ppIq4mxdebns9x5wa&pullRequest=588

Check failure on line 17 in src/test/java/net/openhft/chronicle/map/fromdocs/CustomCharSequenceEncodingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIY7mxdebns9x5v9&open=AZ0ppIY7mxdebns9x5v9&pullRequest=588

Check warning on line 192 in src/test/java/net/openhft/chronicle/map/MemoryLeaksTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertEquals instead. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGYWhSD72ysnLwt9&open=AZ0ffGYWhSD72ysnLwt9&pullRequest=588

Check warning on line 80 in src/test/java/net/openhft/chronicle/hash/impl/util/ThrowablesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGluhSD72ysnLwwe&open=AZ0ffGluhSD72ysnLwwe&pullRequest=588

Check warning on line 168 in src/test/java/net/openhft/chronicle/map/ChronicleMapImportExportTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.InterruptedException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIdRmxdebns9x5wE&open=AZ0ppIdRmxdebns9x5wE&pullRequest=588

Check warning on line 82 in src/test/java/net/openhft/chronicle/map/fromdocs/acid/revelations/DirtyReadVictimTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffFfihSD72ysnLwof&open=AZ0ffFfihSD72ysnLwof&pullRequest=588

Check warning on line 1409 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 28 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIs7mxdebns9x5wh&open=AZ0ppIs7mxdebns9x5wh&pullRequest=588

Check warning on line 659 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGXvhSD72ysnLwts&open=AZ0ffGXvhSD72ysnLwts&pullRequest=588

Check warning on line 52 in src/test/java/net/openhft/chronicle/map/Issue60Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGOZhSD72ysnLwr0&open=AZ0ffGOZhSD72ysnLwr0&pullRequest=588

Check warning on line 1530 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 26 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIs7mxdebns9x5wi&open=AZ0ppIs7mxdebns9x5wi&pullRequest=588

Check warning on line 1730 in src/test/java/net/openhft/chronicle/map/ChronicleMapTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIvkmxdebns9x5w9&open=AZ0ppIvkmxdebns9x5w9&pullRequest=588

Check warning on line 97 in src/test/java/net/openhft/chronicle/map/MapCloseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGFOhSD72ysnLwrI&open=AZ0ffGFOhSD72ysnLwrI&pullRequest=588

Check warning on line 1960 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 27 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIs7mxdebns9x5wm&open=AZ0ppIs7mxdebns9x5wm&pullRequest=588

Check failure on line 80 in src/test/java/net/openhft/chronicle/map/NestedContextsInIterationContextTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppInImxdebns9x5wR&open=AZ0ppInImxdebns9x5wR&pullRequest=588

Check warning on line 1200 in src/test/java/net/openhft/chronicle/map/ChronicleMapTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.ClassNotFoundException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIvkmxdebns9x5w2&open=AZ0ppIvkmxdebns9x5w2&pullRequest=588

Check warning on line 691 in src/test/java/net/openhft/chronicle/map/jsr166/JSR166TestCase.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Swap these 2 arguments so they are in the correct order: expected value, actual value. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGEphSD72ysnLwq3&open=AZ0ffGEphSD72ysnLwq3&pullRequest=588

Check warning on line 2066 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce the number of assertions from 27 to less than 25. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIs7mxdebns9x5wn&open=AZ0ppIs7mxdebns9x5wn&pullRequest=588

Check failure on line 68 in src/test/java/net/openhft/chronicle/map/MapCloseTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppImGmxdebns9x5wP&open=AZ0ppImGmxdebns9x5wP&pullRequest=588

Check warning on line 684 in src/test/java/net/openhft/chronicle/map/CHMUseCasesTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGXvhSD72ysnLwtt&open=AZ0ffGXvhSD72ysnLwtt&pullRequest=588

Check warning on line 198 in src/test/java/net/openhft/chronicle/map/MemoryLeaksTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This block of commented-out lines of code should be removed. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ffGYWhSD72ysnLwt-&open=AZ0ffGYWhSD72ysnLwt-&pullRequest=588

Check failure on line 858 in src/test/java/net/openhft/chronicle/map/ChronicleMapTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case. 

See more on https://sonarcloud.io/project/issues?id=OpenHFT_Chronicle-Map&issues=AZ0ppIvkmxdebns9x5wr&open=AZ0ppIvkmxdebns9x5wr&pullRequest=588
View more details on SonarQubeCloud