Skip to content

fix(code-review): drop 🟢 Acceptable/Nit inline comments#207

Merged
xingyaoww merged 1 commit into
mainfrom
drop-green-acceptable-comments
Apr 23, 2026
Merged

fix(code-review): drop 🟢 Acceptable/Nit inline comments#207
xingyaoww merged 1 commit into
mainfrom
drop-green-acceptable-comments

Conversation

@xingyaoww
Copy link
Copy Markdown
Member

Summary

Remove 🟢 Acceptable and 🟢 Nit inline comments from the review bot's output. These green comments are pure noise — they create review threads that the PR author must resolve without providing any actionable value.

Changes

skills/github-pr-review/SKILL.md

  • Removed 🟢 Nit and 🟢 Acceptable rows from the priority labels table
  • Added explicit "Do NOT post" guidance in their place
  • Updated the summary checklist: labels are now 🔴🟠🟡 only, replaced "mark acceptable trade-offs" with "only comment when action is needed", clarified that clean code gets a short approval with no inline comments

skills/code-review/SKILL.md

  • Added a no-green-comments rule to the [STYLE NOTES] output section reinforcing that acceptable/fine code should not generate inline comments

Motivation

During the review of PR #206, the bot posted 3 "🟢 Acceptable" inline comments that just said "this is fine" in different ways. Each one created a review thread that had to be acknowledged and resolved. This is wasted effort for the PR author and adds visual clutter for reviewers scanning the PR. If code is acceptable, the correct action is to not comment on it at all.


This PR was created by an AI assistant (OpenHands) on behalf of the user.

@xingyaoww can click here to continue refining the PR

Remove the green Acceptable and Nit priority labels from the
github-pr-review skill and add explicit guidance in both the
github-pr-review and code-review skills to never post inline
comments for code that is fine.

These comments create review threads that must be resolved without
providing any actionable value — pure noise for the PR author.

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Copy Markdown
Member Author

Review instruction: Do not post 🟢 Acceptable or 🟢 Nit inline comments — only comment on items that need action.

@xingyaoww xingyaoww requested a review from all-hands-bot April 23, 2026 17:33
Copy link
Copy Markdown
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Elegant solution that eliminates noise.

Directly addresses the clutter from 🟢 Acceptable/Nit comments experienced in PR #206. The changes are clear, consistent across both skills, and follow the principle: if code is acceptable, don't comment on it.

[RISK ASSESSMENT]
⚠️ Risk Assessment: 🟢 LOW

Documentation-only change that improves signal-to-noise ratio in reviews. No API breakage, clear behavior change with strong rationale.

VERDICT:
Worth merging

KEY INSIGHT:
Removing comments that say "this is fine" is a perfect example of eliminating special cases - good code needs no praise, only problems need attention.

@xingyaoww xingyaoww marked this pull request as ready for review April 23, 2026 17:37
Copy link
Copy Markdown
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean execution of the "don't comment on acceptable code" principle.

The changes are consistent across both skills: priority labels trimmed to 🔴🟠🟡, explicit "Do NOT post" guidance added, and checklist updated. Directly addresses the noise from PR #206 with a minimal, focused solution.

[RISK ASSESSMENT]
⚠️ Risk Assessment: 🟢 LOW

Documentation-only change that improves signal-to-noise ratio. No API breakage, clear behavior change with strong rationale.

VERDICT:
Worth merging

KEY INSIGHT:
If code is acceptable, the correct action is to not comment on it at all - this PR practices what it preaches.

@xingyaoww xingyaoww merged commit e732290 into main Apr 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants