fix(code-review): drop 🟢 Acceptable/Nit inline comments#207
Conversation
Remove the green Acceptable and Nit priority labels from the github-pr-review skill and add explicit guidance in both the github-pr-review and code-review skills to never post inline comments for code that is fine. These comments create review threads that must be resolved without providing any actionable value — pure noise for the PR author. Co-authored-by: openhands <openhands@all-hands.dev>
|
Review instruction: Do not post 🟢 Acceptable or 🟢 Nit inline comments — only comment on items that need action. |
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Elegant solution that eliminates noise.
Directly addresses the clutter from 🟢 Acceptable/Nit comments experienced in PR #206. The changes are clear, consistent across both skills, and follow the principle: if code is acceptable, don't comment on it.
[RISK ASSESSMENT]
Documentation-only change that improves signal-to-noise ratio in reviews. No API breakage, clear behavior change with strong rationale.
VERDICT:
✅ Worth merging
KEY INSIGHT:
Removing comments that say "this is fine" is a perfect example of eliminating special cases - good code needs no praise, only problems need attention.
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean execution of the "don't comment on acceptable code" principle.
The changes are consistent across both skills: priority labels trimmed to 🔴🟠🟡, explicit "Do NOT post" guidance added, and checklist updated. Directly addresses the noise from PR #206 with a minimal, focused solution.
[RISK ASSESSMENT]
Documentation-only change that improves signal-to-noise ratio. No API breakage, clear behavior change with strong rationale.
VERDICT:
✅ Worth merging
KEY INSIGHT:
If code is acceptable, the correct action is to not comment on it at all - this PR practices what it preaches.
Summary
Remove 🟢 Acceptable and 🟢 Nit inline comments from the review bot's output. These green comments are pure noise — they create review threads that the PR author must resolve without providing any actionable value.
Changes
skills/github-pr-review/SKILL.mdskills/code-review/SKILL.md[STYLE NOTES]output section reinforcing that acceptable/fine code should not generate inline commentsMotivation
During the review of PR #206, the bot posted 3 "🟢 Acceptable" inline comments that just said "this is fine" in different ways. Each one created a review thread that had to be acknowledged and resolved. This is wasted effort for the PR author and adds visual clutter for reviewers scanning the PR. If code is acceptable, the correct action is to not comment on it at all.
This PR was created by an AI assistant (OpenHands) on behalf of the user.
@xingyaoww can click here to continue refining the PR