Skip to content

🏗️🔧:take the label back off once answered - #1818

Merged
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/take-the-label-back
Aug 15, 2026
Merged

🏗️🔧:take the label back off once answered#1818
openinf-commit-queue[bot] merged 1 commit into
livefrom
fix/take-the-label-back

Conversation

@DerekNonGeneric

Copy link
Copy Markdown
Member

The queue removed commit-queue when it refused, but left it in place when it landed — so a merged pull request went on advertising work that was already done.

The label is a request rather than a state. Once the queue has answered it, either way, it has been spent.

  • Removing it cannot start another run: unlabeled is not among the events this workflow listens for, only labeled.
  • Failing to remove it will not fail a run that has already merged, hence || true.
  • Both the removal and the failure comment are skipped when the token could not be minted, since neither can work without one.

Note

This pull request will not clean up after itself. pull_request_target takes the workflow from the base branch, so landing this one runs live's copy — the version that leaves the label on. The first pull request to take its own label off is the one after this.

The label was removed when the queue refused and left in place when it
landed, so a merged pull request went on advertising work the queue had
already finished.

It is a request rather than a state: once answered, either way, it has
been spent. Removing it cannot start another run, since `unlabeled` is
not one of the events this workflow listens for, and failing to remove
it will not fail a run that has already merged.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@netlify

netlify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit d545ce1
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a7fe8370b5d130008976cee
😎 Deploy Preview https://deploy-preview-1818--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@DerekNonGeneric DerekNonGeneric added the commit-queue Land this pull request when its checks pass label Aug 15, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit 9495f78 into live Aug 15, 2026
15 checks passed
@DerekNonGeneric DerekNonGeneric added commit-queue Land this pull request when its checks pass dependencies javascript Pull requests that update Javascript code and removed commit-queue Land this pull request when its checks pass labels Aug 15, 2026
@openinf-commit-queue openinf-commit-queue Bot removed the commit-queue Land this pull request when its checks pass label Aug 15, 2026
@DerekNonGeneric DerekNonGeneric removed javascript Pull requests that update Javascript code dependencies labels Aug 15, 2026
@OpenINF OpenINF deleted a comment from openinf-commit-queue Bot Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant