🏗️🚮：remove what nothing reads - #1824
Merged
Merged
Conversation
Four things that had stopped meaning anything. `tools/archetypes/default.html` is a Hugo idea, from before this site was built with eleventy, and nothing in the repository mentions archetypes. `tools/remark-lint-rules/` and `tools/remark-plugins/` have held nothing but a `.gitkeep` since they were made; the rules and plugins they were for are configured in `.remarkrc.mjs` instead. `toc: true` in the agent forwarding page is read by no layout, include or config, so it has been describing a table of contents that was never rendered. Each was checked for references before going, and the build writes the same 34 files afterwards. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added
the
commit-queue
openinf-commit-queue
Bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four things that had stopped meaning anything, and the first pull request to land under branch protection.
tools/archetypes/default.html— a Hugo idea from before this site was built with eleventy. Nothing in the repository mentions archetypes.tools/remark-lint-rules/andtools/remark-plugins/— nothing but a.gitkeepsince they were created. The rules and plugins they were for are configured in.remarkrc.mjs.toc: trueinagent-forwarding.md— read by no layout, include or config, so it described a table of contents that was never rendered.Each checked for references before removal; the build writes the same 34 files afterwards.
Branch protection is now on
liveRequired checks: Lint and test, CodeQL, Analyze (javascript-typescript), Scan. Also linear history, no force pushes, no branch deletion. No required reviews, and
enforce_adminsoff so you keep an override.Two checks were deliberately not required, because a required check that never reports blocks a pull request forever:
Title and descriptionif: !endsWith(…'[bot]'), so it never reports on a Renovate pull request — requiring it would deadlock every dependency updateLandThe four that are required were verified to report on a markdown-only pull request (#1817) and a JSON-only one (#1806), not just on ones that touch code.
Third-party checks — Codacy, Socket Security, the Netlify rules — are left unrequired, so an outage in someone else's service cannot wedge the repository.
strictis off deliberately: requiring branches to be up to date withlivebefore merging would mean rebasing every pull request whenever anything lands, and the queue would refuse them as behind.What this pull request is really testing
That the commit queue can still land through protection. If the app needed a bypass entry, this is where it shows.