Jaguar2: extend the firmware channel-switch fast path to the 8821C (+ validate the 8822E)#324
Merged
Merged
Conversation
The fw fast path (H2C 0x1D SINGLE_CHANNELSWITCH_V2) was gated to ChipVariant::C8822B, but the whole path is variant-generic — the HMEBOX H2C submit and the RF18 low-byte channel confirm are identical on both Jaguar2 dies, and the vendor 8821C firmware carries the same rtw_ch_switch_offload. Drop the variant restriction so DEVOURER_FASTRETUNE_FW covers both 8822B and 8821C. Also validates the 8822E on-air (an RTL8822EU was on the rig, previously mislabelled): 36<->40 fw 1.92 ms median dead air (n=797, p99 5.16), in line with the 8822C. Coverage now: fw fast path on all four Jaguar2/3 dies; on-air-validated on 8822B, 8822C, 8822E; 8821C code-covered pending a hardware pass (no 8821C part on the rig). Docs + config knob + CLAUDE.md updated to state the per-die coverage. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two coverage gaps in
DEVOURER_FASTRETUNE_FWsurfaced by a per-chip audit of the FHSS series.8821C — code gap closed
The fw fast path (H2C 0x1D
SINGLE_CHANNELSWITCH_V2) was gated toChipVariant::C8822B, but the path is entirely variant-generic — the HMEBOX H2C submit and the RF18 low-byte channel confirm are identical on both Jaguar2 dies, and the vendor 8821C tree carries the samertw_ch_switch_offload/SINGLE_CHANNELSWITCH_V2. Dropping the variant restriction extends the knob to the 8821C. No 8821C part was on the rig, so this is code-covered pending a hardware pass (stated honestly in the docs); the 8822B path is unchanged and re-confirmed (still takesj2fw).8822E — validated on-air
An RTL8822EU was on the rig all along (it had been mislabelled an 8811AU — devourer reports chip-id 0x17). Running the fastretune arm on it: 36↔40 fw 1.92 ms median dead air (n=797, p99 5.16), in line with the 8822C. That upgrades the 8822E from "shipped, code-path-only" to on-air-validated.
Coverage now
The fw fast path covers all four Jaguar2/Jaguar3 dies (8822B, 8821C, 8822C, 8822E). On-air-validated: 8822B, 8822C, 8822E. Code-covered pending hardware: 8821C. Jaguar1 has no such firmware switch; Kestrel is a separate architecture.
docs/kernel-channel-switch-offload.md,docs/frequency-hopping.md, theDeviceConfigknob doc, and both CLAUDE.md files state the per-die status.ctest 36/36; build clean on the affected target.
🤖 Generated with Claude Code