Skip to content

Fix readonly variable crash in non-tty environments #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristopherA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix readonly variable crash in non-tty environments #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/lib/_Z_Utils.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,8 +1446,12 @@ function z_Setup_Environment() {

# Set up terminal capabilities if not already set
function setup_Terminal_Capabilities() {
# Only initialize if they aren't already defined
if [[ -z "$Term_Reset" ]]; then
# Only initialize if they aren't already declared.
# Check variable existence, not emptiness: in non-tty environments,
# Term_Reset is set to empty string at line ~302 but is still readonly.
# Using -z would see "empty" and try to re-set it, crashing with
# "read-only variable".
if ! typeset -p Term_Reset >/dev/null 2>&1; then
# Initialize terminal capabilities
typeset -g Term_Reset="$(tput sgr0 2>/dev/null || echo '')"
typeset -g Term_Bold="$(tput bold 2>/dev/null || echo '')"
Expand Down