Open
Conversation
Nipodemos
reviewed
Oct 16, 2019
Nipodemos
reviewed
Oct 16, 2019
Nipodemos
reviewed
Oct 16, 2019
Nipodemos
reviewed
Oct 16, 2019
Henrybk
reviewed
Oct 18, 2019
Contributor
Author
|
Or should I add possibility not to set price at all? |
Contributor
|
it's good to leave the possibility to not set price |
Nipodemos
requested changes
Oct 24, 2019
Contributor
|
i just tested your PR, and when price is not set, it stills queues buyAuto, go to npc, start buy sequence, but it doesn't buy anything, and never ends buyAuto |
Contributor
Author
|
Still price not required. Fixes in if conditions. |
Contributor
|
in what server have you tested? i'm testing here in RMS and it is not working at all... edit: i honestly don't know what the problem is, but on master branch it is working normally |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, sorry its the last time i hope. Testers Required!