Skip to content

changes to start hotkey reader earlier before server is fully started#1085

Open
venmanyarun wants to merge 2 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix
Open

changes to start hotkey reader earlier before server is fully started#1085
venmanyarun wants to merge 2 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix

Conversation

@venmanyarun
Copy link
Copy Markdown
Contributor

@venmanyarun venmanyarun commented May 18, 2026

Fixes OpenLiberty/ci.maven#1638
Attaching screeen recording

early_exist_dev_mode_gradle.mov

@venmanyarun venmanyarun requested a review from cherylking May 18, 2026 11:24
Copy link
Copy Markdown
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good..just make sure all tests pass and revert yml changes before merging

Also, testing all those hot keys in one test method seems problematic. What if dev mode finishes starting before it has looped through all the options?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev mode should listen for a 'q' keyboard input at an earlier point in the startup sequence, and stop Liberty server if needed

2 participants