Skip to content

changes to start hotkey reader earlier before server is fully started#2019

Open
venmanyarun wants to merge 6 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix
Open

changes to start hotkey reader earlier before server is fully started#2019
venmanyarun wants to merge 6 commits into
OpenLiberty:mainfrom
venmanyarun:early_stop_fix

Conversation

@venmanyarun
Copy link
Copy Markdown
Contributor

@venmanyarun venmanyarun commented May 15, 2026

Fixes #1638

Ci.common changes are addressed in OpenLiberty/ci.common#517

Attaching screen recording

early_exist_dev_mode.mov

After the change, when user hits q and enter, application is quitting without the full deployment

@venmanyarun venmanyarun requested a review from cherylking May 15, 2026 11:24
Copy link
Copy Markdown
Member

@cherylking cherylking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just revert yml changes before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev mode should listen for a 'q' keyboard input at an earlier point in the startup sequence, and stop Liberty server if needed

2 participants