fix: preserve saved subtitle style when rendering - #4
Open
z2z23n0 wants to merge 1 commit into
Open
Conversation
z2z23n0
marked this pull request as ready for review
July 10, 2026 09:33
Author
|
PTAL when you have a chance, @zimoCCC @yhzx233 @gaoyang07. Thanks! |
z2z23n0
force-pushed
the
fix/preserve-saved-subtitle-style
branch
from
July 23, 2026 08:47
3907484 to
7cc86a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Subtitle style updates are persisted on the job, but rendering without a request body rebuilt
SubtitleStylefromNone. That silently restored default font size, margin, and speaker names instead of using the saved style.Fix
job.subtitle_stylewhen the render request omits a style payload.Tests
python -m pytest -q tests/test_app_api.py(4 passed)python -m pytest -q(28 passed)