[A2-k] 张俊鹏 - 第二次提交 - #153
Open
lalalalulu2 wants to merge 3 commits into
Open
Conversation
WillQvQ
requested changes
Aug 8, 2026
WillQvQ
left a comment
Contributor
There was a problem hiding this comment.
审核结论:需要修改后再合并。
当前有三项明确阻塞:
- PR 同时新增
students/张俊鹏/assignments/A2-K/与完整的students/张俊鹏/assignments/A2-P/。仓库要求一个 PR 只修改一名同学的一项作业;请将 A2-P 拆到独立 PR,本 PR 只保留 A2-K。 - 标题应严格使用
[A2-K] 张俊鹏 - 简短说明,当前[A2-k]大小写不符合约定;PR 描述中的“作业编号:A0”、空白基本信息和未填写 checklist 也应更新为本次 A2-K 的真实状态。 - 当前附带的 A2-P CSV 使用 CRLF,导致
git diff --check报告大量 trailing whitespace;拆分 A2-P 时也请统一为 LF。
A2-K 本身的 Triton 实现、6 项 GPU test、正确性记录、矩阵与 23 GiB allocator guard 已完成静态核验;完成上述范围与元数据修复后可继续复核。
审核者:GPT-5.6 Sol Ultra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
基本信息
修改范围
students/_template、公共题面或仓库配置。[A编号] 姓名 - 简短说明。公开性与安全
git diff --cached,没有提交大型数据、模型权重、缓存或完整日志。双层提交
README.md提供可公开、已脱敏的作业报告。README.md已填写飞书补充文档链接。A1 额外检查
若本 PR 不是 A1,请将本节标记为不适用。
README.md、submission/cs336_basics/、submission/tests/adapters.py、submission/scripts/和logs/。README.md(Markdown)。assignment1-basics工作仓库位于 SummerQuest 的兄弟目录,且没有被提交到本 PR。../assignment1-basics运行官方测试,并使用同步脚本更新个人提交目录。A0 额外检查
若本 PR 不是 A0,请将本节标记为不适用。
nvidia-smi与gpustat并记录退出码。A2-P 额外检查
若本 PR 不是 A2-P,请将本节标记为不适用。A2-P 已正式发布,按题面要求提交。
README.md、submission/profiling/**/*.py、规定的轻量results/和至少三张被报告引用的裁剪、压缩图片。scripts/sync_a2p_submission.py和scripts/validate_repo.py。torch.profiler完成两个模型规模 × 三个 context 的六个train_steptrace。.nsys-rep、snapshot、完整 trace、权重、数据、压缩包、上游代码或依赖环境。results/与assets/合计不超过 2 MiB,Profile 只保留关键汇总与截图。A2-K 额外检查
若本 PR 不是 A2-K,请将本节标记为不适用。A2-K 已正式发布,按题面要求提交。
README.md、A2-K Python allowlist、全部规定的轻量results/和至少两张被报告引用的压缩图片。
scripts/sync_a2k_submission.py、官方 GPU tests 和scripts/validate_repo.py,且没有把 CUDA skip 写成 pass。前设置 23552 MiB allocator 上限。
memory_evidence.json已记录 allocator limit/fraction、peak allocated/reserved 和24 GiB 判定。
results/与assets/合计不超过 2 MiB,关键数字可回到轻量结果与命令。给助教的说明
<说明未完成项、环境限制或希望重点审核的内容。不要粘贴密钥和内部地址。>