[A2-P] 刘子源 - 完成 Profiling 性能分析作业 - #155
Open
Zyrrick wants to merge 1 commit into
Open
Conversation
WillQvQ
requested changes
Aug 8, 2026
WillQvQ
left a comment
Contributor
There was a problem hiding this comment.
审核结论:需要修改后再合并。
范围、Python 解析、benchmark、六个 train_step profile、mixed precision、附件预算、安全扫描与 git diff --check 均通过;当前阻塞集中在 Memory Profiling:
submission/profiling/a2_runner.py::run_memory()在 warm-up 后直接 reset peak 并调用torch.cuda.memory._snapshot(),全程没有启用torch.cuda.memory._record_memory_history(...)。因此现有代码不能支撑 README 中“memory-history / Active Memory Timeline”的可复现声明。请在 warm-up 完成后启用 history、采集独立 snapshot,并据此重建/更新两张 timeline 与 metadata。- 题面规定 XL/context 2048、batch 1 OOM 后依次尝试 XL/context 1024、Large/context 2048,并保留原配置、阶段、异常和峰值。当前报告说明 XL/1024 未成功初始化、Large/2048 仅有 forward OOM,却改用未规定的 Medium/context 512 train-step 作为 fallback。请补齐规定顺序中与失败 workload 对应的结构化记录;若确因平台/CUDA 初始化阻塞,也需记录失败阶段、异常类型、已尝试命令和联系助教情况,不能用 Medium/512 代替规定 fallback。
- README 同时写“memory profiling 均已完成”和“XL/1024 fallback 未完成”,请在补测后统一完成状态;若仍受基础设施阻塞,应明确列为限制而不是完成。
修复并重新 push 后可复核。
审核者:GPT-5.6 Sol Ultra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
基本信息
修改范围
students/_template、公共题面或仓库配置。[A编号] 姓名 - 简短说明。公开性与安全
git diff --cached,没有提交大型数据、模型权重、缓存或完整日志。双层提交
README.md提供可公开、已脱敏的作业报告。README.md已填写飞书补充文档链接。A2-P 额外检查
若本 PR 不是 A2-P,请将本节标记为不适用。A2-P 已正式发布,按题面要求提交。
README.md、submission/profiling/**/*.py、规定的轻量results/和至少三张被报告引用的裁剪、压缩图片。scripts/sync_a2p_submission.py和scripts/validate_repo.py。torch.profiler完成两个模型规模 × 三个 context 的六个train_steptrace。.nsys-rep、snapshot、完整 trace、权重、数据、压缩包、上游代码或依赖环境。results/与assets/合计不超过 2 MiB,Profile 只保留关键汇总与截图。